ignore_case fix for aiogram.filters.command.Command() (#1107)

* ignore_case fix

* Create 1106.bugfix.rst

* better fix, added tests

* Update 1106.bugfix.rst

* fix, attempt to satisfy the linter

* not on purpose, single quotes in tests
This commit is contained in:
Alex 2023-02-04 19:52:36 +02:00 committed by GitHub
parent fad45c66aa
commit 3428924d63
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 32 additions and 2 deletions

View file

@ -35,6 +35,23 @@ class TestCommandFilter:
assert cmd.commands[0] == "start"
# assert cmd == Command(commands=["start"])
@pytest.mark.parametrize(
"commands,checklist",
[
[("Test1", "tEst2", "teSt3"), ("test1", "test2", "test3")],
[("12TeSt", "3t4Est", "5TE6sT"), ("12test", "3t4est", "5te6st")],
[[BotCommand(command="Test", description="Test1")], ("test",)],
[[BotCommand(command="tEsT", description="Test2")], ("test",)],
[(re.compile(r"test(\d+)"), "TeSt"), (re.compile(r"test(\d+)"), "test")],
],
)
def test_init_casefold(self, commands, checklist):
command = Command(*commands, ignore_case=True)
assert command.commands == checklist
command = Command(*commands, ignore_case=False)
assert command.commands != checklist
@pytest.mark.parametrize(
"text,command,result",
[
@ -72,10 +89,15 @@ class TestCommandFilter:
["/start test", CommandStart(deep_link=True), True],
["/start test", CommandStart(deep_link=True, deep_link_encoded=True), False],
["/start dGVzdA", CommandStart(deep_link=True, deep_link_encoded=True), True],
["/TeSt", Command("test", ignore_case=True), True],
["/TeSt", Command("TeSt", ignore_case=True), True],
["/test", Command("TeSt", ignore_case=True), True],
["/TeSt", Command("test", ignore_case=False), False],
["/test", Command("TeSt", ignore_case=False), False],
["/TeSt", Command("TeSt", ignore_case=False), True],
],
)
async def test_parse_command(self, bot: MockedBot, text: str, result: bool, command: Command):
# TODO: test ignore case
# TODO: test ignore mention
message = Message(