python/aiogram
1
0
Fork 0
mirror of https://github.com/aiogram/aiogram.git synced 2025-12-11 18:01:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Added get_url() method for Message object and shifted_id property for Chat object (#585)

Browse source 
* Added get_url() method for Message object and shifted_id property for Chat object

* Added missing closing bracket to shifted_id description

* Added basic groups to skipped pattern, simplified code

* Return None instead of raising TypeError, removed redundant f-string

* Change get_url typing to Optional[str]

* Better shifted_id method

* get_url tests added

* Added whitespace (E226)

* Code format with black

* Parametrized test
This commit is contained in:
Aleksandr 2021-06-05 13:37:01 +03:00 • committed by GitHub
parent 53da50045e
commit 32bc05130f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 86 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

51
tests/test_api/test_methods/test_get_url.py Normal file
View file

@ -0,0 +1,51 @@
import datetime
from typing import Optional
import pytest
from aiogram.types import Chat, Message
from tests.mocked_bot import MockedBot
class TestGetMessageUrl:
@pytest.mark.parametrize(
"chat_type,chat_id,chat_username,force_private,expected_result",
[
["private", 123456, "username", False, None],
["group", -123456, "username", False, None],
["supergroup", -1001234567890, None, False, "https://t.me/c/1234567890/10"],
["supergroup", -1001234567890, None, True, "https://t.me/c/1234567890/10"],
["supergroup", -1001234567890, "username", False, "https://t.me/username/10"],
["supergroup", -1001234567890, "username", True, "https://t.me/c/1234567890/10"],
["channel", -1001234567890, None, False, "https://t.me/c/1234567890/10"],
["channel", -1001234567890, None, True, "https://t.me/c/1234567890/10"],
["channel", -1001234567890, "username", False, "https://t.me/username/10"],
["channel", -1001234567890, "username", True, "https://t.me/c/1234567890/10"],
# 2 extra cases: 9-digit ID and 11-digit ID (without "-100")
["supergroup", -100123456789, None, True, "https://t.me/c/123456789/10"],
["supergroup", -10012345678901, None, True, "https://t.me/c/12345678901/10"],
],
)
def test_method(
self,
bot: MockedBot,
chat_type: str,
chat_id: int,
chat_username: Optional[str],
force_private: bool,
expected_result: Optional[str],
):
fake_chat = Chat(id=chat_id, username=chat_username, type=chat_type)
fake_message_id = 10
fake_message = Message(
message_id=fake_message_id,
date=datetime.datetime.now(),
text="test",
chat=fake_chat,
)
if expected_result is None:
assert fake_message.get_url(force_private=force_private) is None
else:
assert fake_message.get_url(force_private=force_private) == expected_result